Accessing static property Rangka\Quickbooks\Services\Customer::$responseHasRoot as non static

rangka / quickbooks

PHP Library for connecting to QuickBooks.

MIT License

8 stars 11 forks source link

Accessing static property Rangka\Quickbooks\Services\Customer::$responseHasRoot as non static #17

Closed renedekat closed 7 years ago

renedekat commented 7 years ago

Hi,

In the Service model there is a static class variable that is access through $this-> a few time.

PHP Generates warning for this.

Shouldn't that variable declaration be:

protected  $responseHasRoot = true;

It's set to false in TaxService.php .

renedekat commented 7 years ago

I see you changed that, but in release 0.1.7 (which is your latest) this wasn't the case. It was calling $this->responseHasRoot which is what I spotted when using it.

khairulashraff commented 7 years ago

Ah darn it I must have forgotten to make a release as it was made by a contributor with some minor changes by me. My apologies on that.

v0.1.8 is now released with the fix.