search

rangka / quickbooks

PHP Library for connecting to QuickBooks.
MIT License
8 stars 11 forks source link

Style and PHPDoc fixes #19

Closed renedekat closed 7 years ago

renedekat commented 7 years ago

Fixed some PHPDoc blocks: incorrect return types/ missing @param

Ran it through StyleCI

khairulashraff commented 7 years ago

I'm not quite sure what you expect me to do with this. The code style fixes aside (which I personally dislike), you went as far as changing the namespace and package name, especially bad is the namespace. You can't just change a namespace like that. Imagine the havoc it would cause on projects that uses this library. You should keep those changes in your fork and not request for a merge.

The only thing I would merge in are the extra setters as those are indeed useful.

renedekat commented 7 years ago

Sorry, I changed the namespace after I created the PR, because I wanted to make some changes to my forked branch.

Didn't know that would be reflected in the Pull Request after it had been created.