search

rangle / angular-devtools

Moved to the Angular organization.
https://github.com/angular/angular/tree/master/devtools
255 stars 18 forks source link

Support Electron #849

Closed TobiasTao closed 2 years ago

TobiasTao commented 3 years ago

Angular DevTools version (required): 1.0.2

Angular version (required): 12.0.2

Link to a minimal stackblitz reproduction (strongly encouraged):

Description of issue:

image

Steps to reproduce:

git clone https://github.com/TobiasTao/angular-electron
cd angular-electron
npm install
npm run start

error msg:

[10168:0606/004415.854:ERROR:CONSOLE(0)] "Unchecked runtime.lastError: Could not establish connection. Receiving end does not exist.", source: chrome-extension://lkopochcppfakkbkbhpfnlddnijpffef/index.html (0)

Additional details:

BenjaminDobler commented 3 years ago

I tracked it down to chrome.browserAction calls in background.ts. I guess these are unsupported in electron. If i comment those calls the extension works nicely in electron. Also adding a try catch around these calls fixes the issue.

bampakoa commented 2 years ago

I have tested it with the latest version of the extension 1.0.4 and it works as expected 😃

TobiasTao commented 2 years ago

🎉