search

rangle / augury

Angular Debugging and Visualization Tools
https://augury.rangle.io
MIT License
2.01k stars 216 forks source link

fix #1405 Router tree is not scrollable #1406

Closed gnowland closed 4 years ago

gnowland commented 4 years ago

fixes #1405 Router tree is not scrollable Inline CSS: svg {max-height: 100%; } being imported from basscss is preventing scroll. Setting bt-router-tree svg { max-height: none !important; } enables scroll.

yallen011 commented 4 years ago

Hi @gnowland I just checked with the current code base and the fix for this was merged back in April with the following pull request #1382 I am not sure if the fix made it in time for the prod build but it is was working when i tested the dev version. I also noticed that your router-tree.css code seemed to be outdated. Did you sync with the forked branch prior to creating this fix?

gnowland commented 4 years ago

Did you sync with the forked branch prior to creating this fix?

It was a fresh fork made specifically to fix this issue, strange there would be anything out of date... in fact the only difference between your master branch and my commit is the 4 lines as far as I can tell: https://github.com/rangle/augury/compare/master...gnowland:039fdd5ca8c7da198cbf66efe4a0defe01f93e0a

gnowland commented 4 years ago

re-built from latest master and router tree scrolls correctly - closing issue and PR!