rangle / ngCourse2

An Angular Course from Rangle.io
Other
184 stars 126 forks source link

Sharing the same dependency injection tree - we shouldn't need to reimport SharedModule #883

Closed housseindjirdeh closed 7 years ago

housseindjirdeh commented 7 years ago

In the Modules section: Sharing the Same Dependency Injection Tree, we reimport SharedModule into our lazily loaded module which isn't needed if we define it as a core module in our application root with forRoot. This can apparently cause issues as well.

Will put up a PR to update this page and the plunker as well.