Refactor: Storybook React for 6.4.22

rangle / radius

A design system accelerator

https://rangle.io/radius/

MIT License

173 stars 24 forks source link

Refactor: Storybook React for 6.4.22 #114

Closed usrrname closed 2 years ago

usrrname commented 2 years ago

update CSF (Component Story Format) to CSF 4
remove deprecated addons or params in Storybook config
convert config files in .storybook/ to .ts from .js
updates README.md with file structure

Branches for maintenance:

basic-css ✅
basic-styled ✅
basic-emotion ✅

usrrname commented 2 years ago

@rafRangler @sumitarora I need some advice here on what to run to impact test that my changes to Storybook did not cause any breakages to other areas.

In what order are you running such commands? npm run prepare npm run rollup npm run build:lib

rafRangler commented 2 years ago

npm run rollup is the new way to create a build (only the component library) with rollup. You can ignore npm run prepare for now since that's to create a build before publishing.

Lastly, npm run build:lib is for creating a build with tsdx... but I'm not too sure if we're going to continue using that from now onwards. Kept it there just in case we needed to rollback

rafRangler commented 2 years ago

npm run build:storybook can be used to create a build for storybook :).

usrrname commented 2 years ago

In the process of updating to 6.4.22 the update to storybook-addon-tokens to 2.1.0 actually caused all tokens to be shown in the Colors design token doc block mdx, so we had to walk it back to 1.4.0