rangle / rangle-starter

48 stars 23 forks source link

yarn on CI? #189

Open SethDavenport opened 7 years ago

SethDavenport commented 7 years ago

I'm a big fan of yarn: https://yarnpkg.com/

I don't think we should require people to use it, but it might be worth getting it to work on CI for reliability (yarn.lock) and build speed.

Should just be a matter of updating the circle.yaml as follows:

machine:
  node:
    version: 6
dependencies:
  pre:
    - npm install -g yarn@0.16.1
  override:
    - yarn install
test:
  pre:
    - yarn run clean
    - yarn run test:lint
  override:
    - yarn test
general:
  artifacts:
    - "./coverage"

And also doing yarn install locally and checking in the yarn.lock file.

SethDavenport commented 7 years ago

Yes, we want it :)

SethDavenport commented 7 years ago

We won't force people to use it; things will still work using npm. But CI will use yarn.

SethDavenport commented 7 years ago

Added to api-koa-starter. Also boosted the node requirement to v6 since it's LTS now.

SethDavenport commented 7 years ago
bennett000 commented 7 years ago

https://circleci.com/docs/yarn/

SethDavenport commented 7 years ago

You may need to switch your circle ci settings to use ubuntu 14.04 containers