Open radziksh opened 7 years ago
Yes you're totally right. We've done this for our other example apps but the react one needs some attention. Feel like making a PR? :)
well, ok. You have saved my time. I will save yours ;)
I added @types and application works but there is some error with npm test
:
21 01 2017 22:38:19.957:ERROR [karma]: Error: Invalid store [fslookup], allowed values are at Object.create (C:\typescript-react-redux-example\node_modules\remap-istanbul\node_modules\istanbul\lib\util\factory.js:47:28) at new HtmlReport (C:\typescript-react-redux-example\node_modules\remap-istanbul\node_modules\istanbul\lib\report\html.js:350:15) at C:\typescript-react-redux-example\node_modules\remap-istanbul\lib\writeReport.js:76:20 at C:\typescript-react-redux-example\node_modules\remap-istanbul\node_modules\amdefine\amdefine.js:125:34 at _combinedTickCallback (internal/process/next_tick.js:67:7) at process._tickCallback (internal/process/next_tick.js:98:9) npm ERR! Test failed. See above for more details.
Hi, again me:) as typescript 2.0 is used in starter, then there is new typing system for definitions from https://github.com/DefinitelyTyped/DefinitelyTyped project. so instead code in
typing.json
:can be used code in `package.json':
and typescript 2.0 will automatically handle it. https://blogs.msdn.microsoft.com/typescript/2016/06/15/the-future-of-declaration-files/