rangle / redux-beacon

Analytics integration for Redux and ngrx/store

https://rangle.gitbook.io/redux-beacon/

MIT License

668 stars 73 forks source link

fix issue #333 - Error when trying to track e-commerce items in GA #335

Closed wermetal closed 5 years ago

wermetal commented 5 years ago

Checklist

[x] Fix issue #333 - Error when trying to track e-commerce items in GA following documentation

What was done

I have changed functions ecommSend and ecommClear to return type EventDefinition. We don't need any information about action, prevState and nextState to send e-commerce data to GA, so I did not add any additional function parameter to ecommSend and ecommClear like in other helpers.

Associated Issues

333

ttmarek commented 5 years ago

This is awesome @wermetal, thanks again.

The fix is available on npm under: @redux-beacon/google-analytics@1.2.1