search

rangle / redux-beacon

Analytics integration for Redux and ngrx/store
https://rangle.gitbook.io/redux-beacon/
MIT License
668 stars 73 forks source link

Update README with redux-dynamic-modules-beacon info #342

Closed dbartholomae closed 5 years ago

dbartholomae commented 5 years ago

Add information about redux-dynamic-modules-beacon extension.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

What was done

Added documentation

Associated Issues

:heart: Thanks

Thanks for taking the time to help out with the project, it's much appreciated :slightly_smiling_face:

ttmarek commented 5 years ago

Looks good! One quick question before merging in case anyone asks in the future. What's the difference between the "integration" and "integrates with" columns? What should go in which?

dbartholomae commented 5 years ago

The idea is that if you want to integrate redux-beacon with something that does not support redux-beacon out-of-the-box, then you need two libraries: the library you want to integrate with, and the connector between the two. So in this case if you want to integrate redux-beacon with redux-dynamic-modules, you need redux-dynamic-modules-beacon to do so.

ttmarek commented 5 years ago

That's a good enough explanation for me! Thanks @dbartholomae. I've just merged this. The docs should deploy with the changes automatically in the next few minutes.