why not support org? - Githubissues

ranguard / text-vcard

Perl package to edit and create vCard(s) (RFC 2426)

22 stars 15 forks source link

Closed worthmine closed 7 years ago

worthmine commented 9 years ago

use Carp and replace die to croak, add ORG parameter

kablamo commented 9 years ago

I really appreciate the pr @worthmine ! Unfortunately I won't get a chance to review this until June 13th at the earliest. Very sorry about that.

worthmine commented 9 years ago

I don’t hurry about that. thx

ranguard commented 7 years ago

@worthmine if you have the time and can rebase this, and get the tests passing, I'll get this merged and deployed.

worthmine commented 7 years ago

Now I'm writing what should I do with Moose and it works well. But I'm sorry that I can't write the tests! Because I have not written them never.

Anyway, I will make public what I wrote when I have the time to do.

ranguard commented 7 years ago

@worthmine The existing tests are failing (see the pull request on github) - the Travis CI link - that's what needs to be updated to pass.

Let me know if you need any help - many thanks

worthmine commented 7 years ago

@ranguard Hey I’ve just written the patch passing the tests! but i can't make new pull request with this.

worthmine commented 7 years ago

I could! please check pr #45

ranguard commented 7 years ago

@worthmine looks good - I'll give it a day for anyone to feedback on then merge and deploy - thank you so much.

Closing this pull in favour of #45