Update to yew 0.19 - Githubissues

ranile / material-yew

Yew wrapper for Material Web Components

https://material-yew.rm.rs

Apache License 2.0

230 stars 35 forks source link

Update to yew 0.19 #18

Closed dcchut closed 2 years ago

dcchut commented 2 years ago

Notes:

Running cargo +nightly fmt generated a lot of whitespace changes in html!() calls, which is unfortunate.
Cow<'static, str> replaced with Option<AttrValue> since IntoPropValue is not implemented on Cow anymore.
InputData was removed from yew. I've made some (presumably quite dodgy) changes to handle this - this is probably worth having a closer look at.

Resolves #15

ranile commented 2 years ago

Thanks for this PR! I don't think this crate was ever going to be updated if not for you doing it.

It would be great if you could also update mwc. All you have to do is update the npm package, invoke rollup and accommodate for breaking changes as described in the changelog. That can be a separate PR. I'll go ahead and merge this one.

jens1205 commented 2 years ago

This PR is not yet available on crates.io? There I can only see 0.1.0

ranile commented 2 years ago

Yes, it hasn't yet been published. If you want to use it, you need to use a git dependency:

material-yew = { git = "https://github.com/hamza1311/material-yew/", features = ["full"] }

jens1205 commented 2 years ago

Thanks for the immediate response. yes, git dependency is working (first time I used this, so thanks for the opportunity :-))

Is anything preventing the official publishing of the new version?

ranile commented 2 years ago

Hi, sorry for the very late response. I've published a new version.

cc @jens1205