ranjitjhala / sprite-lang

An tutorial-style implementation of liquid/refinement types for a subset of Ocaml/Reason.
BSD 3-Clause "New" or "Revised" License
146 stars 13 forks source link

Fix logical connective `&&` #5

Closed shingarov closed 1 year ago

shingarov commented 1 year ago

Currently in all L₂—L₈, both && and || parse to BOr. I believe this is unintentional as there is a BAnd defined but not used. It also causes confusion (it cost me a while of head-scratching trying to understand why some of my experiments weren't typechecking before I realized this was going on).

ranjitjhala commented 1 year ago

OMG thank you very much for finding and fixing this!!!