search

ranking-agent / aragorn-ranker

Exposes TRAPI functions to add literature co-occurrence edges, convert publications to edge weights, and provide scores for answers.
MIT License
0 stars 1 forks source link

Better attribute handling #24

Open cbizon opened 3 years ago

cbizon commented 3 years ago

I am not 100% sure I'm correct, but it looks as though weight_correctness is adding an attribute "weight" to an edge, not using TRAPI attributes. It should use a TRAPI attribute instead properly formatted so that weight_correctness could be used as a component whether our scorer was to be used or not.

Then in scorer, it seems as though that's being converted into "has quotient" which does not seem like a good property for this attribute. If there is not something in biolink that is more appropriate, we should try to get something else added.

Probably we should have the scorer take the property name to use as a weight in its calculations rather than assuming it will be one particular property or another.

PhillipsOwen commented 3 years ago

i can see that it is reading the Attributes object properly. but on the way out the weight attribute is not added properly. i will repair.

as far as the score type i will change that to EDAM:data_1669/biolink:has_numeric_value.

cbizon commented 3 years ago

I'm not sure I totally understand your comment above. But... Please verify that the output from weight correctness validates and consult with the biolink group for the appropriate property.