search

ranking-agent / aragorn

A Translator ARA combining asynchronous database querying, answer coalescence, and answer ranking.
MIT License
4 stars 3 forks source link

Add qualified_predicate #234

Open cbizon opened 7 months ago

cbizon commented 7 months ago

When we make an inferred edge for the increases/decreases activity or abundance queries, we should be adding a qualified predicate = causes to the edge. See https://github.com/NCATSTranslator/Feedback/issues/744

cbizon commented 7 months ago

So ARAGORN is just taking the input qgraph edge and copying it into the inferred edge. The qualified_predicate isn't in the qgraph, so it doesn't get onto the inferred edge.

Either 1) It does get added to the qgraph, in which case, it will automatically show up in the result BUT we'll need to be sure that we still recognize it as an MVP2 query or 2) It doesn't get added in the qgraph and we need to special case it (bleah).

Either way, pushing to Eel

cbizon commented 4 months ago

Originally the idea was to have the UI send these in. But adding it to the UI caused problems for other ARAs. So we hsould probably go ahead and add this in. Fugu if we can.

cbizon commented 4 months ago

The issue with BTE has been solved, so perhaps the UI will pass the qual pred in. Take care of in guppy either way.

cbizon commented 2 months ago

Needs retest