search

ranking-agent / aragorn

A Translator ARA combining asynchronous database querying, answer coalescence, and answer ranking.
MIT License
4 stars 3 forks source link

Lookup separate from infer #263

Open cbizon opened 2 months ago

cbizon commented 2 months ago

We want to return both lookup and infer queries for MVP1 and 2. To do this, we expand the query and then send the direct lookup along with the rules to multistrider.

But mutlistrider runs those however asyncio decides it should and we sometimes never get the known results back.

Perhaps there would be a way to handle this in strider, but it seems like the simplest thing is to send the direct edge as a single lookup edge to strider independently of the rules and then merge them all. This will all but guarantee that we get the known results back, which should also help with our must show test results.

capasfield commented 2 weeks ago

Chris - locate the related feedback issue and tag it here.

cbizon commented 2 weeks ago

Possibly related to https://github.com/NCATSTranslator/Feedback/issues/706#event-14085157500

In Aragorn meeting 8/30, @maximusunc also reminded us of the problem where sub-predicate queries can produce this kind of result. This is sort of fixed in "treats" queries, but not in chemical/gene queries. So if we have a case where we want "chemical increases activity of gene" and we have a query that includes "chemical affects gene" and there is actual lookup results, then they will get returned as matching the affects, but we'll think it's a support rather than a lookup.

We "fixed" it in treats by modifying the rules, but I think that now we need to be smarter and actually fix fix it.