search

ranking-agent / robokop-ara

0 stars 1 forks source link

Fix env deployment #41

Closed maximusunc closed 2 years ago

maximusunc commented 2 years ago

Remove all hard-coded external service URLs and enable setting them as environment variables. This will help future deployments when external service URLs change.

codecov-commenter commented 2 years ago

Codecov Report

Merging #41 (8bb9980) into main (8089e55) will increase coverage by 1.36%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   83.63%   85.00%   +1.36%     
==========================================
  Files           4        5       +1     
  Lines         110      120      +10     
==========================================
+ Hits           92      102      +10     
  Misses         18       18
Impacted Files Coverage Δ
app/trapi.py 96.66% <75.00%> (-3.34%) :arrow_down:
app/config.py 100.00% <100.00%> (ø)
app/identifiers.py 60.71% <100.00%> (+1.45%) :arrow_up:
app/server.py 86.36% <100.00%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8089e55...8bb9980. Read the comment docs.