search

ranking-agent / strider

A TRAPI-compliant component of ARAGORN that queries distributed KPs and assembles answers to user questions.
MIT License
3 stars 0 forks source link

500 on bad query #364

Closed uhbrar closed 2 years ago

uhbrar commented 2 years ago

This PR fixes the strider 500 on a bad query as mentioned in #362.

However, doing this also has some odd effects. For one thing, we actually do get some results now, which doesn't make sense to me. I don't really know how or why any KP would be sending us anything, but we are receiving response with 23 results back from Genetics KP. This clearly shouldn't be happening.

cbizon commented 2 years ago

For the genetics KP, can you make an issue on their repo please?

uhbrar commented 2 years ago

This actually looks like a repeat of this same issue: https://github.com/broadinstitute/genetics-kp-dev/issues/26

@cbizon Should I make a new issue anyway? I'm pretty sure resolving that earlier issue will address this as well.

kennethmorton commented 2 years ago

@uhbrar Just tack on a message with a reference back here.