ranking-agent / strider

A TRAPI-compliant component of ARAGORN that queries distributed KPs and assembles answers to user questions.
MIT License
3 stars 0 forks source link

No AuxGraphs #411

Closed cbizon closed 1 year ago

cbizon commented 1 year ago

BTE is returning auxgraphs, but strider is not passing them along.

For a treats lookup query (MONDO:0018912) BTE is using auxiliary graphs to denote a subclass result. So they have an edge with a support graph property. The name of the support graph ends up looking like support0-PUBCHEM.COMPOUND:44139752-treats-MONDO:0018912-via_subclass

When I run the inferred lookup query for that id through strider, I don't think that the auxiliary graph is ever being returned (though the support-graph attribute is in place). That leads to some downstream dangling pointers.

maximusunc commented 1 year ago

Could you post the original query please?

cbizon commented 1 year ago
{
    "message": {
        "query_graph": {
            "nodes": {
                "disease": {
                    "ids": [
                        "MONDO:0018912"
                    ]
                },
                "chemical": {
                    "categories": [
                        "biolink:ChemicalEntity"
                    ]
                }
            },
            "edges": {
                "t_edge": {
                    "object": "disease",
                    "subject": "chemical",
                    "predicates": [
                        "biolink:treats"
                    ]
                }
            }
        }
    }
}
maximusunc commented 1 year ago

Should be fixed in https://github.com/ranking-agent/strider/pull/413/commits/b3e3ba1f131741ca436596545a02f173e94a85ad

maximusunc commented 1 year ago

Confirmed on dev that auxiliary graphs are being returned!