search

ranking-agent / strider

A TRAPI-compliant component of ARAGORN that queries distributed KPs and assembles answers to user questions.
MIT License
3 stars 0 forks source link

Some nodes are missing from result edges #442

Closed maximusunc closed 1 week ago

maximusunc commented 6 months ago

PK in CI: 067ed81a-dada-4334-8140-4792c9c2d1d9

cbizon commented 6 months ago

I (accidentally) ran with cache-override on, and it produced the same problem. It seems that there is one node missing: PUBCHEM.COMPOUND:12198448, which is referenced in 3 edges (all support edges somewhere I think)

maximusunc commented 6 months ago

Update: I believe I've tracked this down to a kp giving back a subclass result without a corresponding query id. We try and handle that and just assign it a valid query id, but I think that is causing this issue. Strider ends up returning an edge binding in the results that references the subclass node, but nothing else references it. Then Aragorn scores/sorts/filters, and the kgraph orphan filter then filters that node out, causing the TRAPI validation error.

I think we should probably just throw out any subclass results without a valid query id. In this case, there was only 1. I had only added this temporary query id fix because the automats weren't returning it correctly and didn't want to throw them all out.

cbizon commented 6 months ago

OK, let's make sure we complain back to the relevant KP.

From: Max Wang @.> Sent: Friday, March 1, 2024 11:48 AM To: ranking-agent/strider @.> Cc: Bizon, Christopher A @.>; Comment @.> Subject: Re: [ranking-agent/strider] Some nodes are missing from result edges (Issue #442)

Update: I believe I've tracked this down to a kp giving back a subclass result without a corresponding query id. We try and handle that and just assign it a valid query id, but I think that is causing this issue. Strider ends up returning an edge binding in the results that references the subclass node, but nothing else references it. Then Aragorn scores/sorts/filters, and the kgraph orphan filter then filters that node out, causing the TRAPI validation error.

I think we should probably just throw out any subclass results without a valid query id. In this case, there was only 1. I had only added this temporary query id fix because the automats weren't returning it correctly and didn't want to throw them all out.

— Reply to this email directly, view it on GitHubhttps://github.com/ranking-agent/strider/issues/442#issuecomment-1973528660, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACR7EHQKLZQYMFSO4C5FNKTYWCWPVAVCNFSM6AAAAABD2TU7KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZTGUZDQNRWGA. You are receiving this because you commented.Message ID: @.***>

maximusunc commented 1 week ago

This has been fixed in #451 !