rankmath / seo-by-rank-math

Rank Math is a revolutionary WordPress SEO Plugin that combines the features of many SEO tools and lets you multiply your traffic in the easiest way possible :bulb: :chart_with_upwards_trend: →
https://rankmath.com
107 stars 52 forks source link

Divi integration breaks certain Divi module(s) in the Divi visual builder #265

Open jonmarkhall opened 8 months ago

jonmarkhall commented 8 months ago

The add_et_tag() function in this plugin's Divi integration prevents loading of various scripts in the Divi visual builder by adding the et_fb_ignore_iframe class to their script tags:

https://github.com/rankmath/seo-by-rank-math/blob/657ebb1fc1e528b10d5d7a352c171dd403d77d89/includes/3rdparty/divi/class-divi.php#L280

This breaks some Divi module(s) that depend on these scripts being loaded in the visual builder. Notably, Divi modules that rely on the WordPress script i18n API for translation functions (provided by the wp-i18n script) may crash without this script; however, there are probably also other problems caused by preventing core JavaScript files from loading in the visual builder.