search

rankmath / seo-by-rank-math

Rank Math is a revolutionary WordPress SEO Plugin that combines the features of many SEO tools and lets you multiply your traffic in the easiest way possible :bulb: :chart_with_upwards_trend: →
https://rankmath.com
107 stars 52 forks source link

The string "Make Term Primary" is hardcoded and not translatable #285

Closed DAnn2012 closed 2 weeks ago

DAnn2012 commented 3 months ago

Describe the bug The string "Make Term Primary" is hardcoded and not translatable

Expected behavior The "Make Term Primary" string should use WordPress' i18n functions and be translatable

Screenshots

247857059-b3b42768-ed31-45b7-89e4-667fbb9afe91

https://github.com/rankmath/seo-by-rank-math/blob/84827ce80b23c72e893d527e32d38b9b02ffad48/assets/admin/src/classic/components/PrimaryTerm.js#L35

https://github.com/rankmath/seo-by-rank-math/blob/84827ce80b23c72e893d527e32d38b9b02ffad48/assets/admin/src/classic/components/PrimaryTerm.js#L102

Also in these lines of this file there are hardcoded and untranslatable strings:

https://github.com/rankmath/seo-by-rank-math/blob/84827ce80b23c72e893d527e32d38b9b02ffad48/assets/admin/src/classic/Assessor.js#L77

https://github.com/rankmath/seo-by-rank-math/blob/84827ce80b23c72e893d527e32d38b9b02ffad48/assets/admin/src/classic/Assessor.js#L81

DAnn2012 commented 2 months ago

Hi @pratikrm

please could you kindly take a look at this my Issue report?

Thank you.

balazsrm commented 2 months ago

Hi @DAnn2012, Thank you for bringing these issues to our attention. We'll get them fixed in an update soon.

pratikrm commented 2 weeks ago

Hi @DAnn2012

We have fixed this issue in v1.0.225.

DAnn2012 commented 2 weeks ago

Hi @pratikrm

Thank you for the reply.

I had already noticed this, but I see that the file "/assets/admin/js/classic.js" has been updated with the changes and therefore the files that are in the path "/assets/admin/src/classic/" are to be considered obsolete?

Thanks.

pratikrm commented 2 weeks ago

Hi @DAnn2012

The files in the assets/admin/src directory are source files that are not executed directly by the plugin. These source files are compiled using a compiler into the assets/admin/js folder, and the compiled files are then used by the plugin.