ranm8 / requestify

Simplifies node HTTP request making.
http://ranm8.github.io/requestify
MIT License
223 stars 55 forks source link

Error thrown in NodeJs 0.12.0 #25

Closed rgeraldporter closed 9 years ago

rgeraldporter commented 9 years ago
node_modules/requestify/node_modules/jquery/node_modules/jsdom/lib/jsdom/level1/core.js:418
set nodeName() { throw new core.DOMException();},
             ^
SyntaxError: Unexpected token )

JsDOM actually fixed this issue a while back, and jQuery no longer uses JsDOM. Probably need to upgrade the jQuery version to run in v0.12 of Node.

bweston92 commented 9 years ago

Same issue here. Any update?

bweston92 commented 9 years ago

We need to update jQuery.

thedug commented 9 years ago

Any eta on when this will be available?

dermotos commented 9 years ago

I'm also experiencing this.

bweston92 commented 9 years ago

I've made a PR it is today with jQuery with one of the dependencies.

— Sent from Mailbox

On Sun, Feb 22, 2015 at 2:54 AM, Dermot notifications@github.com wrote:

I'm also experiencing this.

Reply to this email directly or view it on GitHub: https://github.com/ranm8/requestify/issues/25#issuecomment-75416480

ranm8 commented 9 years ago

Thanks. Fixed on 0.1.17. Update to latest 0.1.x and it will be ok.

Anyway, I'm planning to remove jQuery from core at version 0.2.0 and distribute as a separate project that extends Requestify. Hopefully the version will be delivered in the next few weeks.

Closing...

seemasohoni commented 9 years ago

Hi there,

I have downloaded NodeJs 0.12.0 and after trying to compile using grunt-cli I see the following exception: ...grunt release Loading "cancompile.js" tasks...ERROR

SyntaxError: /Users/../../content/catalog/node_modules/can-compile/node_modules/jsdom/lib/jsdom/level1/core.js:450 set childNodes() { throw new core.DOMException();}, ^ Unexpected token ) Warning: Task "cancompile" not found. Use --force to continue.

I aded the following to my jquery 's package.json.. "optionalDependencies" :{ "jsdom": “3.1.1” }, However I still see the same problem.

Couple of questions:

  1. One of the above solutions is to bump up the jquery version in package.json, but which package.son are you referring to, should there be one under nom something?
  2. The version of query that I have installed is 2.1.3, i.e > 1.8.3

Can you please help?

andersonmadeira commented 9 years ago

Using nodejs 12.1 here and the issue still persists.