rannn505 / child-shell

Node.js bindings 🔗 for shell
http://rannn505.github.io/child-shell/
MIT License
301 stars 71 forks source link

Powershell Core Feedback #72

Closed ALIENQuake closed 5 years ago

ALIENQuake commented 5 years ago

Hi,

  1. Powershell Core is the only version which is available for Linux and macOS, so the ability to use "usePWSH" parameter should be allowed only for Windows platform. On Linux and macOS usage of pwsh should be default and should not require additional parameters/configuration.

  2. Because how Powershell Core is distributed and installed on Windows platform, it should be possible to use pwsh executable which was distributed inside application itself, either from top-level or from 'powershell' directory. I think that adding 'https://www.npmjs.com/package/pwsh' as dependency could help achieving this goal.

  3. Powershell Core has now also 'pwsh-preview' executable for preview versions.

@rannn505 This feedback is based on @BenjaminMichael version but it seems likely that his PR will be merged. Thoughts?