ransome1 / sleek

todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
https://github.com/ransome1/sleek/wiki
MIT License
1.34k stars 104 forks source link

Sidebar tooltips "undefined" or missing #436

Closed CPUGPU closed 1 year ago

CPUGPU commented 1 year ago

Is it an actual bug? Yes, though minor and cosmetic. I don't think "undefined" or blank would be intentional.

Did you check if the bug has already been reported? Searching for "undefined" and "tooltip" revealed no existing issues.

Describe the bug Mouseover the icons in the sidebar. The "+" icon pops-up "Add a new todo" tooltip, the parameters icon shows "View"; both good. However the filter icon shows "undefined" and the folder icon shows nothing.

To Reproduce Steps to reproduce the behavior:

  1. Mouseover the filter icon in the sidebar, pause, see the "undefined" tooltip.
  2. Mouseover the folder icon, pause, see nothing.

Do you see any error entries in sleeks developer tools? No obviously relevant errors.

Expected behavior The filter icon should say "Filter" (at least). The folder icon should say "Manage Lists" or at least "Lists" or maybe "Files".

The problem look like "filter" is missing from src/locales/en/translation.json, and the "title" setAttribute is for navBtnOpenTodoFile is missing from src/js/navigation.mjs. I've updated both of these in my fork, but can't get Yarn to install on my machine so I can't test them. I can still submit the pull request.

Screenshots Peek 2022-11-05 16-19

Desktop (please complete the following information):

ransome1 commented 1 year ago

@CPUGPU thanks for reporting this. Could you please check if this is solved in 1.2.9?

CPUGPU commented 1 year ago

Victory! Thank you.