search

ransome1 / sleek

todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
https://github.com/ransome1/sleek/wiki
MIT License
1.33k stars 104 forks source link

sleek v2 regresses behaviour of friendly dates #535

Closed gdarcy closed 10 months ago

gdarcy commented 11 months ago

Bug Report

IMPORTANT: Please follow this template strictly when reporting bugs. Providing detailed and accurate information helps the development team to understand and address the issue effectively.

App Version: v2.0.0-dev12

Platform: Windows

Installation Method: Direct Download

Bug Description: When adding a date by day name, days earlier in the week are interpreted as the date earlier in the week rather than the date in the following week.

Steps to Reproduce:

  1. Specify a date (verified with due and threshold) by naming the day of the week as a day that has already passed (note that SugarJS considers that the week starts on Sunday)
  2. Observe that the actual date selected is a date that has already passed.

Expected Behavior: The ambiguous date should be interpreted as a future date. This was previously addressed against #199 in sleek v1.x.

Actual Behavior: The ambiguous date is currently interpreted as being in the current week regardless of whether that is a past or future date.

Reproducibility:

Impact:

ransome1 commented 10 months ago

@gdarcy has been released as part of https://github.com/ransome1/sleek/releases/tag/v2.0.0-dev15. Could you please check if it works on your side as expected?

gdarcy commented 10 months ago

@ransome1 Thanks, this works as expected for both due and threshold dates -- "Monday" is correctly interpreted as October 16th rather than October 9th.

ransome1 commented 10 months ago

Thanks again for being attentive and providing the PR.