ransome1 / sleek

todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
https://github.com/ransome1/sleek/wiki
MIT License
1.33k stars 104 forks source link

Error in completion format #538

Closed antoniopaolini closed 10 months ago

antoniopaolini commented 10 months ago

Bug Report

App Version: [2.0.0-dev13]

Platform: [macOS ]

Installation Method: [Direct Download ]

Bug Description: If I mark task completed the 1.3.1 version save it moving the priority in property, like pri:C, to be clear. The 2.0.0-dev13 instead modify the row by adding x in front but leave the priority in place. This conflict with the format rule n°2 for complete task, that say: Rule 2: The date of completion appears directly after the x, separated by a space.

Steps to Reproduce:

  1. Write down a task with priority
  2. mark as completed
  3. open the todo.txt file with a text editor or another todo.txt app (in the screenshots is TodoTxtMac)

Screenshots: Screenshot 2023-10-02 alle 01 34 52 copia

Screenshot 2023-10-02 alle 01 50 33 copia

System Information:

Reproducibility:

Impact:

ransome1 commented 10 months ago

@antoniopaolini this should be fixed in https://github.com/ransome1/sleek/releases/tag/v2.0.0-dev15. Could you please check if it works on your side?

It has a limitation though. If you restore a todo with pri:, it will not remove the extension itself.

So if x Test pri:A is marked as incomplete again, it will create (A) Test pri:A. This is due to the todo.txt parser not being able to remove extensions yet. It is addressed with them.

antoniopaolini commented 10 months ago

@antoniopaolini this should be fixed in https://github.com/ransome1/sleek/releases/tag/v2.0.0-dev15. Could you please check if it works on your side?

It has a limitation though. If you restore a todo with pri:, it will not remove the extension itself.

Yes, it's works.