search

ransome1 / sleek

todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
https://github.com/ransome1/sleek/wiki
MIT License
1.33k stars 104 forks source link

Recurring task completion generates a Creation date on the new task when it shouldn't #539

Closed Piscean closed 10 months ago

Piscean commented 10 months ago

Bug Report

IMPORTANT: Please follow this template strictly when reporting bugs. Providing detailed and accurate information helps the development team to understand and address the issue effectively.

App Version: [2.0.0-dev13]

Platform: [Windows]

Installation Method: [Direct Download]

Bug Description: The Settings dialog says "Append creation date when todo is created". I have that turned off. When I complete a recurring task, the newly created task has the creation date at the front of the task.

Steps to Reproduce:

  1. Turn Append creation date off in settings
  2. Create a daily recurring event --> Verify the creation date wasn't prepended
  3. Complete that task --> Check the todo.txt file and you'll see the task now has a creation date prepended.

Expected Behavior: When a recurring task is completed, the newly created future task should not have the creation date, since I have that setting turned off in Settings.

Actual Behavior: All future tasks will have the creation date

Additional Information:

Screenshots: [If applicable, include screenshots that demonstrate the bug.]

System Information:

Reproducibility:

Impact:

Workaround: None

ransome1 commented 10 months ago

@Piscean could you please check if this still occurs in https://github.com/ransome1/sleek/releases/tag/v2.0.0-dev15?

Piscean commented 10 months ago

The creation date is not being added to the new task, so that appears to be fixed!

However, now the completed task has the completion date listed twice.

This was my original task: Recurring test due:2023-10-10 rec:+1d

This is the completed task: x 2023-10-10 2023-10-10 Recurring test due:2023-10-10 rec:+1d

And this is the new task in todo.txt: Recurring test due:2023-10-11 rec:+1d

From: ransome @.> Sent: Tuesday, October 10, 2023 5:36 AM To: ransome1/sleek @.> Cc: Eric @.>; Mention @.> Subject: Re: [ransome1/sleek] Recurring task completion generates a Creation date on the new task when it shouldn't (Issue #539)

@Pisceanhttps://github.com/Piscean could you please check if this still occurs in https://github.com/ransome1/sleek/releases/tag/v2.0.0-dev15?

— Reply to this email directly, view it on GitHubhttps://github.com/ransome1/sleek/issues/539#issuecomment-1755317247, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAQUJ3LWUJNUJ3C6DPCVUO3X6U6M3AVCNFSM6AAAAAA5OW4HBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJVGMYTOMRUG4. You are receiving this because you were mentioned.Message ID: @.***>

ransome1 commented 10 months ago

However, now the completed task has the completion date listed twice.

That is not a double completion date, it is actually creation and completion date. Unfortunately the todo.txt parser (jsTodoTxt in the latest version) refuses to add a completion date, if there is no creation date. As a workaround, everytime when a todo is marked as complete, a creation date needs to be added by sleek. So in case a todo did not already have a creation date, todays date will be added as creation date. As long as this behavior doesn't change upstream, we need to live with this workaround.

The issue has been raised here.

Piscean commented 10 months ago

Okay, that makes sense. Thank you. Please consider this solved and close the bug.

Eric

From: ransome @.> Sent: Tuesday, October 10, 2023 11:00 AM To: ransome1/sleek @.> Cc: Eric @.>; Mention @.> Subject: Re: [ransome1/sleek] Recurring task completion generates a Creation date on the new task when it shouldn't (Issue #539)

However, now the completed task has the completion date listed twice.

That is not a double completion date, it is actually creation and completion date. Unfortunately the todo.txt parser (jsTodoTxt in the latest version) refuses to add a completion date, if there is no creation date. As a workaround, everytime when a todo is marked as complete, a creation date needs to be added by sleek. So in case a todo did not already have creation date, todays date will be added. As long as this behavior doesn't change upstream, we need to live with this workaround.

The issue has been raised herehttps://github.com/jmhobbs/jsTodoTxt/issues/50.

— Reply to this email directly, view it on GitHubhttps://github.com/ransome1/sleek/issues/539#issuecomment-1755958178, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAQUJ3LTPUKG67KOCPQBMK3X6WEMHAVCNFSM6AAAAAA5OW4HBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJVHE2TQMJXHA. You are receiving this because you were mentioned.Message ID: @.***>