`Esc` does not exit the search menu

ransome1 / sleek

todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)

https://github.com/ransome1/sleek/wiki

MIT License

1.37k stars 105 forks source link

`Esc` does not exit the search menu #553

Closed swantzter closed 11 months ago

swantzter commented 11 months ago

Bug Report

IMPORTANT: Please follow this template strictly when reporting bugs. Providing detailed and accurate information helps the development team to understand and address the issue effectively.

App Version: 2.0.0-dev17

Platform: Windows

Installation Method: Direct Download

Bug Description: pressing Esc with the search bar focused does not close the search bar as expected

Steps to Reproduce:

Open the search bar Ctrl+F (this also auto-focuses it)
Press Esc

Expected Behavior: The search bar would close and show me my file tabs again

Actual Behavior: either a) nothing or, when I had a side panel open (like filters) b) the side panel was closed

ransome1 commented 11 months ago

@swantzter I would suggest the following behavior:

If search field is open and has a value, escape will empty it. That's how it is done in many of the GUIs I use.
If search field is open and empty, escape will close search field and show file tabs again
If drawer is open and search field is open, escape will not close drawer
If drawer is open and search field is closed, escape will close drawer
CMD or Ctrl + F won't change

swantzter commented 11 months ago

Yeah, that sounds sensible to me.

My only thought would be that for search field is open and empty I would only expect it to close if it was focused. (and I would expect Ctrl+F to re-focus it if it wasn't focused)

ransome1 commented 11 months ago

Fully agree. Will be part of the next release.

I'm thinking about releasing the current state as 2.0 soon. Besides the already reported minor issues and improvement requests, does this build feel stable in general?

swantzter commented 11 months ago

I think so, I'll note that I started using sleek with 2.0 dev releases and haven't used 1.x, so I'm not sure if there's something glaring missing. But 2.0 has been working well and been stable for me in general.

Only minor thing I have noticed that I haven't opened an issue about (I'll try to remember to do that) has been with threshold dates when the filters are set to hide todos with thresholds in the future. On the day that the task is supposed to become visible you need to take some action that causes the list to refresh (if you've left the app open) to make the task appear, such as adding a todo or completing a todo.

ransome1 commented 11 months ago

We could add some sort of an auto refresh every couple of minutes.

swantzter commented 11 months ago

Yeah, that was my thought as well

ransome1 commented 11 months ago

Added it to the backlog.

swantzter commented 11 months ago

Tested the new shortcut, it does what I expect it to now. thanks!