search

ransome1 / sleek

todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
https://github.com/ransome1/sleek/wiki
MIT License
1.37k stars 105 forks source link

Win + D shortcut on Linux seems problematic #591

Closed andrei-a-papou closed 10 months ago

andrei-a-papou commented 10 months ago

Bug Report

App Version: 2.0.2

Platform: Linux, Debian 11, Xfce

Installation Method: AppImage from GitHub

Bug Description: Win + D ("hide app") shortcut doesn't work on my machine, in fact, the Win modifier doesn't even register (see screenshot): image

There's no conflict with window manager's keybindings on my machine, but I imagine some people do use Win + D to toggle desktop (a-la Windows).

In addition, clicking the Hide menu item doesn't do anything either.

Personally, I would remove this functionality on Linux as it is rather trivial to implement with third-party apps (e.g. jumpapp) or a bit of scripting (using wmctrl or similar.) That would also ensure there's no conflict with window manager's key bindings.

ransome1 commented 10 months ago

@andrei-a-papou I can confirm, this menu entry has no effect on Linux (I have Ubuntu/Gnome running in a VM here).

Generally, if hiding windows on Linux desktop environments is not common, I agree and we might want to simply remove it from the menu.

Are you familiar with Windows? From what I understand, Windows + D is the OS default keyboard binding to show the desktop and more or less hide all elements, which are currently in foreground. If this is true, I also don't see any good reason to register a keyboard shortcut in sleek, which will never be triggered, since Windows will intercept it anyways. What do you think?

However, on macOS this shortcut (CMD+D) is commonly used.

andrei-a-papou commented 10 months ago

@ransome1 Yes, under Windows Win + D is a hardcoded thing, to show/hide desktop. I can confirm this on Windows 7 (virtual machine). For Windows 10 and 11 it's the same, see this link: https://support.microsoft.com/en-us/windows/keyboard-shortcuts-in-windows-dcc61a57-8ff0-cffe-9796-cb9706c75eec#WindowsVersion=Windows_10.

ransome1 commented 10 months ago

Ok, I will remove this function for Windows and Linux in the next release. Thanks for pointing this out.

andrei-a-papou commented 10 months ago

no problem!

ransome1 commented 10 months ago

@andrei-a-papou the keyboard shortcut for hiding the window should be removed on Linux and Windows in this pre-release: https://github.com/ransome1/sleek/releases/tag/v2.0.3-rc.4

andrei-a-papou commented 10 months ago

Just tested, the menu item's gone, thank you!