search

ransome1 / sleek

todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
https://github.com/ransome1/sleek/wiki
MIT License
1.28k stars 99 forks source link

Creating a new todo while filtered by search will show all todo's #604

Closed swantzter closed 5 months ago

swantzter commented 7 months ago

Bug Report

App Version: 2.0.3-rc.4\ Platform: Windows\ Installation Method: Direct download

Bug Description: If you create a todo while you have filtered todos via the search bar, all todos will become visible (ignoring the search) once you save the todo

Steps to Reproduce:

  1. open search Ctrl+F
  2. Search for something
  3. Create a new task Ctrl+N, "(A) Test test", *add*

Expected Behavior: the filtered list should keep showing, and the newly added todo should be included if matching the search

Actual Behavior: All todos are shown

ransome1 commented 6 months ago

@swantzter can you please check if the latest pre-release solves this issue? https://github.com/ransome1/sleek/releases/tag/v2.0.4-rc.2

swantzter commented 6 months ago

works!

swantzter commented 6 months ago

@ransome1 I will say on an unrelated note, possibly related to the refactoring mentioned in the release notes that 2.0.4-rc.2 has a significantly worse launch time than previous versions on windows (~9s).

ransome1 commented 6 months ago

This might be related to: https://github.com/ransome1/sleek/issues/615

Is this just happening on the latest pre-release or also with the ones as described in 615?

swantzter commented 6 months ago

Possible, I haven't experienced a delay like this on any earlier version, only 2.0.4-rc.2

ransome1 commented 6 months ago

Quick questions:

Does this only happens on Windows, or are you experiencing the same thing on Linux too?

If only on windows: can I ask you to check if Windows Defender is up and running at the same time? I'm asking because I stumbled upon this: https://stackoverflow.com/questions/67982430/windows-defender-slowing-down-electron-startup

And at last: does it only affect the start up or also the actual usage of sleek once loaded?

amariusz commented 6 months ago

works!

Does it really work? I've checked rc.2, rc.3, rc.4 and the latest sleek-2.0.4 and it still resets the search after adding new item. The same also happens when I filter by entering text in search box and mark some item complete - all entries are shown.

ransome1 commented 6 months ago

@swantzter @amariusz I think it has fallen victim to the ongoing refactoring. It should be fixed again in the next release.

ransome1 commented 5 months ago

@amariusz could you please check if it now working as expected in https://github.com/ransome1/sleek/releases/tag/v2.0.6? if so, please feel free to close.

amariusz commented 5 months ago

Searching/filtering and completing tasks works properly now. Searching/filtering and adding new tasks not so much, as clicking "Add as todo" seems to have no action. Although using Ctrl-N as a workaround works great.

Thank you!

ransome1 commented 5 months ago

You're right, one thing fixed, one thing broken. ;) I should really stop adding more features and instead focus on UI test automatization.

ransome1 commented 5 months ago

@amariusz should be fixed in the latest pre-release: https://github.com/ransome1/sleek/releases/tag/v2.0.7-rc.1

amariusz commented 5 months ago

Thanks, it works fine now!

BTW It seems there's new feature that suggests to add filter or select the filter. It tends to get's in the way by obscuring the item(s) being filtered especially if there's one item showing and user is not interested in this functionality. Maybe there should be an option to disable it or initially present it in a form of icon like 🔻 that expands the filter menu after clicking it. I suppose you expect the user to hit enter or escape after entering a query?

ransome1 commented 5 months ago

Thanks, it works fine now!

BTW It seems there's new feature that suggests to add filter or select the filter. It tends to get's in the way by obscuring the item(s) being filtered especially if there's one item showing and user is not interested in this functionality. Maybe there should be an option to disable it or initially present it in a form of icon like 🔻 that expands the filter menu after clicking it. I suppose you expect the user to hit enter or escape after entering a query?

It is not yet a new feature, but a proof of concept for this feature request: https://github.com/ransome1/sleek/issues/179#issuecomment-1890464577

I am collecting feedback over in that issue, could you post your feedback there as well? Then we have one source of truth.

To answer your question: This is the one thing about the feature I too dislike to far. During typing users would always see the Create Filter entry and bothers me as well. Of course a setting could disable it, but that does not yet solve the issue for the users, who want to use it. Let's see what we can do about it.