search

ransome1 / sleek

todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
https://github.com/ransome1/sleek/wiki
MIT License
1.36k stars 106 forks source link

Add "Reset filter and search" from 1.3.2 to sleek 2.0 #612

Open amariusz opened 9 months ago

amariusz commented 9 months ago

Feature Request

Description: "Reset filter and search" was present in sleek-1.3.2-rc.1. It was useful. It seems currently there's no option to quickly reset filters and show all items in todo file.

ransome1 commented 9 months ago

The function exists and can be triggered by its shortcut (Ctrl or CMD + 0) or via the window menu. On Linux and Windows this menu can be made visible pressing the Alt key. A corresponding button has not yet been re-implemented.

amariusz commented 9 months ago

Thanks for info. Ctrl-0 works. Alt menu also works on Linux. However I'm not sure it's good idea to hide menu by default. It should probably be a setting.

ransome1 commented 9 months ago

I remember the discussion about the menu from other issues here. In 2.0.0 the menu was always shown (unlike in 1.3.1 where it was hidden by default) and users were pointing their dislike of this behavior.

So I assume unlike macOS, Windows or Linux don't have a convention here and the behavior might be subject to personal preference. A setting might be an option to improve the UX. I am not even sure, if it needs to be a setting visible in the UI.

Whatever route we're going, it might be a good idea to file a feature request for it and close this one in order to keep the backlog tidy.

amariusz commented 9 months ago

My remark about menu behavior was "on the sidebar." As I now know how to activate it, I don't care so much about the setting. Can we keep this issue open until the button is re-implemented? It was really convenient, in my opinion.

amariusz commented 9 months ago

BTW Ctrl+0 shortcut is not handy for GUI application that relies on using mouse. Ctrl-R (reset filters), Ctrl+Alt+R or Ctrl-E (erase filters) would be better IMO.

andrei-a-papou commented 8 months ago

@amariusz Ctrl+R seems to reload the entire UI so it kind of "resets" everything, although that does not seem to be the original purpose of the shortcut.

@ransome1 Personally I agree it would be nice to have a keyboard shortcut to reset both search and filters. Perhaps Ctrl+Shift+0, by way of analogy to Ctrl+0?

agrudzinsky commented 5 months ago

@ransome1 I agree with @amariusz on most points:

  1. The Ctrl-0 shortcut is not discoverable, especially when the menu is hidden by default.
  2. The Ctrl-0 shortcut resets only filters but not searches. There is a button "Reset filters and searches" that appears on the screen when the list is empty. I'd like to see this button in the sidebar.
  3. Using shortcuts and using mouse are two different modes of operation. I need both hands to press Ctrl-0. I wouldn't mind if I could press the shortcut with my left hand only but, as it is now, I have to take my right hand off the mouse to press Ctrl-0 or press Alt to show the menu then make two clicks through the menu items. That's too many clicks for a basic feature like this.

I'll use Ctrl-R which can be pressed with a left hand only. But it takes visibly longer to reload the whole app than to reset the filters.