search

ransome1 / sleek

todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
https://github.com/ransome1/sleek/wiki
MIT License
1.28k stars 99 forks source link

Right to Left Languages Support #624

Closed gabilevi closed 4 months ago

gabilevi commented 6 months ago

When entering a new task in a right-to-left language, it appears as a reversed sentence. For instance, in Hebrew, "Clean the floor of the house" is displayed as "house the of floor the clean." Changing the interface to right-to-left can also prove beneficial. todo.txt appears to right in utf8 so, the development should be made in the app itself.

ransome1 commented 6 months ago

@gabilevi could you please use the Feature Request template? Thanks.

baruchiro commented 5 months ago

It is a bug, not a feature.

It is caused because every word in a task is wrapped with a div, so the divs are sorted with the app direction, and blocks the natural RTL support.

image

ransome1 commented 5 months ago

@baruchiro @gabilevi while implementing a markdown parser into sleek, the structure of single rows changed a bit. I'm not sure if this solves the issue at hand, but it can't hurt to try it out on your ends: https://github.com/ransome1/sleek/releases/tag/v2.0.9-rc.1

baruchiro commented 5 months ago

Yes, now it's OK.

The app is still directed LTR, of course, but the task text is RTL when it's needed.

ransome1 commented 5 months ago

What does it mean to properly implement RTL support into an application? Is it just about reverting the direction in the input elements?

ransome1 commented 4 months ago

@gabilevi @baruchiro Please feel free to check this pre-release, if the issues described here are being covered: https://github.com/ransome1/sleek/releases/tag/v2.0.9-rc.4

I will merge these changes into the next stable release, unless you tell me not to.

gabilevi commented 4 months ago

it's working ! Looking forward for the next stable release. Thanks for supporting and easing our tasks board!