ransome1 / sleek

todo.txt manager for Linux, Windows and MacOS, free and open-source (FOSS)
https://github.com/ransome1/sleek/wiki
MIT License
1.28k stars 99 forks source link

Better discoverability for inverted filtering #634

Closed andrei-a-papou closed 5 months ago

andrei-a-papou commented 5 months ago

I accidentally just discovered that you can Ctrl-click on a priority badge under "Attributes" tab and "invert" the filtering of todos. E.g. you can search for all todos with a priority of "non-A" this way. I think it's a useful feature (Simpletask offers it as well), but I think some kind of hint in the UI would be useful to help people discover it?

ransome1 commented 5 months ago

@andrei-a-papou I agree and the usage data confirms your assumption. It is already on the backlog of 2.0.7 (https://github.com/users/ransome1/projects/3/views/1) but I'm glad to use this issue here instead. If you like you can use the feature request template and describe the implementation you would expect.

amariusz commented 5 months ago

That's a nice feature! It's probably not documented anywhere?

Mentioning modifier keys with LMB in https://github.com/ransome1/sleek/wiki/Keyboard-shortcuts could be good enough IMO.

ransome1 commented 5 months ago

I added the shortcut to the list: https://github.com/ransome1/sleek/wiki/Keyboard-shortcuts#drawer

But I doubt this solves the issue at hand. If users need to check the list of shortcuts to discover features, I think we should work out another angle as well. I was thinking about using the hovering state of an attribute somehow.

ransome1 commented 5 months ago

I actually removed the Ctrl behavior in 2.0.7. Not because it was hard to find, but foremost because I think it is simply not how these kind of features should work. In the latest released I am proposing a different behavior. If a user hovers a filter button in the attribute drawer, the counter in the badge will change to an icon, which indicates the exclusion.

Screenshot 2024-01-21 at 10 01 10 PM

Click on the eye icon will then exclude todos which contain this filter.

andrei-a-papou commented 5 months ago

Click on the eye icon will then exclude todos which contain this filter.

Thank you, works great. Good UX, in my opinion.