Closed codyaray closed 1 year ago
Thank you @codyaray for this contribution!
Is the only motivation for adding source_dir
and destination_dir
the project name? B/c source
and destination
already are dirs and that could be confusing.
Sorry for the delay. I went OOO right after I sent this. :)
Is the only motivation for adding source_dir and destination_dir the project name? B/c source and destination already are dirs and that could be confusing.
I'm open to whatever naming suggestions you have. I chose "dir" in the spirit of dirname but could be more explicit if it helps. The existing source and destination are full paths, not just the dir names.
ok so how about source_dirname
or source_basename
?
it's longer but can prevent confusion
lgtm, thank you @codyaray
Two small fixes here: