search

ranveeraggarwal / angular-adal-quickstart

Quickstart/Seed for using Microsoft's AAD Authentication with Angular (2/4).
MIT License
21 stars 14 forks source link

Angular 5 support? #12

Closed hkusulja closed 3 years ago

hkusulja commented 6 years ago

Since now Angular 5 is latest, it seems that ngx-adal does not work with Angular 5 nice. Can you check and fix?

ranveeraggarwal commented 6 years ago

There is a PR on the library repo for enabling Angular 5 support. You'll probably have to wait until that is merged.

hkusulja commented 6 years ago

@ranveeraggarwal , yes, waiting about 2 months on this to be merged...

ranveeraggarwal commented 6 years ago

Ah, just saw that :/ Also, turns out the PR has a breaking change.

dave0688 commented 6 years ago

Is there any new on this issue?

kaburkett commented 6 years ago

I found these for Angular 5:

https://github.com/jcmontx/angular5-adal-example

https://github.com/grumar/adal-angular5

hkusulja commented 3 years ago

This is now several years old, also you should use MSAL instead of ADAL library and Angular 5 is definitely old now beeing Angular 12 latest :P

So I am closing this and does not need attention anymore.