raoergsls / miranda

Automatically exported from code.google.com/p/miranda
0 stars 1 forks source link

Bug in vCard (Jabber) #1037

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Miranda Version                  : 0.10.1
Unicode Build                    : Yes
Test Build # (if applicable)     : 0.10.1
Plugin Version # (if applicable) : 0.10.1

Miranda allow type text in telephone and birthday fields. 

VersionInfo
http://www.miranda-vi.org/report/users/andy/

Original issue reported on code.google.com by andrzej....@gmail.com on 9 Oct 2010 at 8:05

GoogleCodeExporter commented 9 years ago
At least a "+" must be allowed for international numbers

Original comment by wishmaster51 on 9 Oct 2010 at 9:33

GoogleCodeExporter commented 9 years ago
Is Miranda doing something against XEP-0054 (or some other XEP) or is this a 
request to make it possible to add information?

Original comment by sami%mir...@gtempaccount.com on 9 Oct 2010 at 9:41

GoogleCodeExporter commented 9 years ago
I think he wants Miranda NOT to allow text in vcard numbers, but after reading 
XEP-0054, I think non-numbers are allowed there

http://xmpp.org/extensions/xep-0054.html

The example itsself is using <NUMBER>303-308-3282</NUMBER>, and as I pointed 
out above, + sign is required for international numbers.

Currently Miranda allows to enter text there, and I think this is correct

Original comment by wishmaster51 on 9 Oct 2010 at 10:31

GoogleCodeExporter commented 9 years ago
As for the birthday, "-" signs MUST be allowed there (see the example above) 
and the text beside explains it, so it should be pretty much idiot-save, but it 
might be better to split it up to
-a control that allowes 4 numbers only (year)
-a dropdown where you can pick the month
-a control that allowes 2 numbers only (date)

Alternatively, a calendar control might be more conveniant

Original comment by wishmaster51 on 9 Oct 2010 at 10:36

GoogleCodeExporter commented 9 years ago
>Currently Miranda allows to enter text there, and I think this is correct

It's not correct. Miranda should have a verification function for special 
fields (telephone numbers, date etc) so user may type only valid date or 
telephone number.

Original comment by andrzej....@gmail.com on 9 Oct 2010 at 8:15

GoogleCodeExporter commented 9 years ago
Who says its not correct? The XEP-0054 dies not say anything like that...

You read the examples I gave you above, didn't you?

Original comment by wishmaster51 on 9 Oct 2010 at 8:37

GoogleCodeExporter commented 9 years ago
Interesting and which format for date to use? Nearly every country have it's 
own ....
Same goes for phone numbers ....

Original comment by borkra on 9 Oct 2010 at 8:41

GoogleCodeExporter commented 9 years ago
I guess this is not corret...
The format of vCard values are here
http://tools.ietf.org/html/rfc2426
and
http://datatracker.ietf.org/doc/draft-ietf-vcarddav-vcardrev/
(Don't ask me why some XEPs examples not follow this rules.)

Referring to this sources dates, this include birthdays have a specific format.
It's defined here http://dotat.at/tmp/ISO_8601-2004_E.pdf (Basic format)
the format for a single date is YYYYMMDD (1985102) and for a full time 
YYYYMMDDThhmmss (19850412T101530)

Therefore, enter ANY text in date/time fields AND use it to store the vCard on 
the server, is not correct, even though clients allow it.

No, Miranda should use the windows default control for date/time input and 
store it in the format that is defined in the rfc, ISO, whatever.

Phone numbers? I am sure, this is defined at another place too, and allow not 
all input.

Peter

Original comment by Lastwebpage@gmail.com on 10 Oct 2010 at 12:32

GoogleCodeExporter commented 9 years ago
Sorry, I was wrong, there are two different specifications, the older from the 
XEP, RFC and the newer one.

Here is an answer from one of the Jabber.org specialist how a client should 
handle this:
http://thread.gmane.org/gmane.network.jabber.standards-jig/24106
A client should display vCards as TEXT but should limit the input to the 
yyyy-MM-DD format.

Original comment by Lastwebpage@gmail.com on 15 Oct 2010 at 1:49

GoogleCodeExporter commented 9 years ago
Ok, devs can decide.

Original comment by sami%mir...@gtempaccount.com on 15 Oct 2010 at 4:53