search

raomin / ESPAltherma

Monitor your Daikin Altherma / ROTEX heat pump with ESP32
MIT License
317 stars 104 forks source link

Add support for M5StickC Plus2 #403

Closed smart40-githib closed 3 months ago

raomin commented 4 months ago

Thanks @smart40-githib, looks good. Did you check retro compatibility with M5StickC?

smart40-githib commented 4 months ago

Unfortunately I only have a Plus2. The changes are mainly to use the appropriate header files when configured for the Plus2 and to replace some unsupported or deprecated calls with the M5Unified equivalents. It should be backwards compatible.

From the issues page I can see that I may have to make a small change so please hold off for now.

smart40-githib commented 4 months ago

The fix has been confirmed good in the issues topic, the pull request is good to go.

redtree99 commented 3 months ago

Hi, Thanks for the fix. Just uploaded it and realised it isn't fully implemented yet, doh. Any idea when support for the plus2 will be in the core code? Many Thanks!

raomin commented 3 months ago

Hmm M5 libs previous plus2 has no M5.Display. Your code breaks for the other env. Is M5.Axp.ScreenBreath(12); not working on M5StickC Plus2

raomin commented 3 months ago

... ah, it doesn't exist on M5Stickc Plus2. I'll make it conditional then...