raouf505 / fairpos

Automatically exported from code.google.com/p/fairpos
0 stars 0 forks source link

Article bundles for e.g. hamper #45

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
By selection of one article, a list of articles should be entered in the ticket 
for e.g. hampers (DE: Geschenkkörbe).
This could also be used for deposit (DE: Pfand), which should automatically 
appear with some drinks.
Rough solution could be nested articles, i.e. articles can have sub-articles.
But big impact, to discuss if this is worth the effort.

Original issue reported on code.google.com by harald.g...@gmail.com on 13 Mar 2012 at 9:57

GoogleCodeExporter commented 8 years ago
Function "Auxiliary Articles" does something similar, but only for articles 
with flag auxiliary and just offers them, does not add them directly. This 
function is thought out for extras in restaurants like sauce, ketchup etc.
Still maybe it could be reused.

Original comment by harald.g...@gmail.com on 13 Mar 2012 at 10:33

GoogleCodeExporter commented 8 years ago
Confirmation: function is really needed.
@Vilem, maybe you can have a look?

Original comment by harald.g...@gmail.com on 28 Mar 2012 at 9:58

GoogleCodeExporter commented 8 years ago
Added support for "Article bundles": in Stock->Auxiliary products, besides 
auxiliary items, also normal items can be now configured as "auxiliary" - ie. 
they are attached to the given article. Unlike attached auxiliary items (which 
are displayed in catalog - on right bottom & can be choosen there), attached 
non-auxiliary items are added immediately after adding of given article to 
ticket.

@Harald: please test & advise next changes

Original comment by benes.vi...@gmail.com on 6 May 2012 at 7:02

GoogleCodeExporter commented 8 years ago
Hey, that's a great idea! Works like charm and still the original auxiliary 
article function remains untouched!
Tested OK!

Original comment by harald.g...@gmail.com on 7 May 2012 at 9:13

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago

Original comment by harald.g...@gmail.com on 22 Jun 2012 at 9:17

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
fixed (r40): Attached non-auxiliary items should appear in ticket as if they 
were auxiliary (with star, with italic font & deleted if their "owner" item 
gets deleted).

Original comment by benes.vi...@gmail.com on 26 Jun 2012 at 9:34

GoogleCodeExporter commented 8 years ago
Logic behind hamper is now: the hamper itself is $0 & all attached items have 
their price (and these can be also removed one by one from ticket) - so total 
price on ticket is given by sum of attached items. 

This is ok in ticket, but where there is only hamper itself (ie. withouth 
attached items visible) listed (eg. in product lists and who knows where else) 
- it has that $0 price (and not the sum it will cost - which is the sum of all 
attached). 

@Harald: Cosmetic or fatal?

Original comment by benes.vi...@gmail.com on 26 Jun 2012 at 9:34

GoogleCodeExporter commented 8 years ago
Sounds like cosmetic, but I'll test this in different scenarios an then I'll 
see.

Original comment by harald.g...@gmail.com on 27 Jun 2012 at 8:50

GoogleCodeExporter commented 8 years ago
Basic idea seems OK so far.
But 3 problems found:
* hamper cannot be added as first article in a ticket (why ever)
* main Article (hamper itself) should not have a "*" in front of the name; for 
the others it should be better a "-"
* you cannot add more than one of an article to a hamper; this should be 
possible by either adding the same article multiple times or by introducing an 
amount to the products_com table - both could be tricky

Furthermore it is difficult to find such "hampered" articles again.
We will need a report for that or the "auxiliary items" window should have a 
list instead of only one main article.

Original comment by harald.g...@gmail.com on 7 Jul 2012 at 9:19

GoogleCodeExporter commented 8 years ago

Original comment by harald.g...@gmail.com on 7 Jul 2012 at 9:21

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
cannot reproduce: * hamper cannot be added as first article in a ticket (why 
ever)

cannot reproduce: * main Article (hamper itself) should not have a "*" in front 
of the name 

fixed (r65): '-' instead of '*' - TODO: change also in database

adding more to hamper: yes, this could be difficult

finding hampered: easiest way now is to create hampers with some convention for 
they reference number (ie. BASKET00-BASKET99) - then in Maintenance->Products 
we have a reference-sorted table (also search works for references in this 
products list)

Original comment by benes.vi...@gmail.com on 9 Jul 2012 at 7:20

GoogleCodeExporter commented 8 years ago
NO BUG: hamper cannot be added as first article in a ticket (why ever) and main 
Article (hamper itself) should not have a "*" in front of the name
My hamper accidentially had a "auxiliary" flag somehow.

TODO: where to change the leading "-" in database?

Finding: OK, let's use the naming convention for now. Also easy is to put them 
all in their own prduct category.

Original comment by harald.g...@gmail.com on 9 Jul 2012 at 7:28

GoogleCodeExporter commented 8 years ago
TODO: change in db: see r65 - change these resources in the same way in: 
Maintenance->Resources. 

Maybe the .xml files could be directly put into DB - see 
https://fairpos.googlecode.com/svn/trunk/OpenbravoPOS/src-pos/com/openbravo/pos/
scripts/PostgreSQL-create.sql
- search eg. for "Printer.Ticket.xml" in it. Note: printerfiscalticket.xml and 
ticketline_taxesincluded.xml are probably not used.

Original comment by benes.vi...@gmail.com on 9 Jul 2012 at 7:45

GoogleCodeExporter commented 8 years ago
As discussed, added resources also in DB and import function for easier editing.
Hampering seems to be finished so far - except adding more than one article.
Replaning this for next milestone to fix this.

Original comment by harald.g...@gmail.com on 10 Jul 2012 at 9:15

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
One drawback of the hamper is that you cannot refund single items of it. This 
should be possible in next milestone.

Original comment by harald.g...@gmail.com on 10 Jul 2012 at 9:33

GoogleCodeExporter commented 8 years ago
adding one article more times to hamper: can be done with '-' and '+' on 
numerical keyboard on main screen in ticket ...clumsy - but better than nothing 
;)

Original comment by benes.vi...@gmail.com on 11 Jul 2012 at 12:47

GoogleCodeExporter commented 8 years ago
For the report printing the article labels, we will need the full price of the 
hamper.
It could also be a second report just for hampers.

Original comment by harald.g...@gmail.com on 21 Jul 2012 at 9:45

GoogleCodeExporter commented 8 years ago
Label printing for hamper postponed... can be put there manually for now.

Original comment by harald.g...@gmail.com on 31 Aug 2012 at 10:19

GoogleCodeExporter commented 8 years ago
Label in a separate job now.
Open points here:
* refund single items -> later milestone (Stock)
* adding more than one article -> should be there when prouctive!

Original comment by harald.g...@gmail.com on 31 Aug 2012 at 10:26

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
> * refund single items
This can be done - just refund (the empty) "main" hamper item, then use "Refund 
one" on any of its contents (ie. attached items). This can use a bit of 
polishing (and also other hamper logic would be nice - eg. "Refund whole 
hamper") but I see this as lower prio - we can do this after we go productive 
...as there will be probably more pressing matters...

> * adding more than one article 
@Harald: just please change the db as follows:

execute: 'drop index pcom_inx_prod' in Postres SQL 
(pgAdmin -> mag glass "SQL" icon -> paste cmd -> F5)
or
do click it in pgAdmin - see picture

Table products_com has now unique index defined, so only one "instance" of one 
product can be added as attached to another product - after deleting this 
index, we can attach multiple instances of the same product to a single 
("hamper") product.

Original comment by benes.vi...@gmail.com on 24 Jan 2013 at 11:38

Attachments:

GoogleCodeExporter commented 8 years ago
To allow multiple articles, but still keep performance, we should drop the 
index, but add another on non-unique. 
Just remove the keyword "UNIQUE" in index create SQL - see below.

-- Index: pcom_inx_prod
DROP INDEX pcom_inx_prod;
CREATE INDEX pcom_inx_prod
  ON products_com
  USING btree
  (product, product2);

Original comment by harald.g...@gmail.com on 2 Feb 2013 at 8:21

GoogleCodeExporter commented 8 years ago
Tested OK.

Original comment by harald.g...@gmail.com on 7 Feb 2013 at 10:38