search

rap2hpoutre / fast-excel

🦉 Fast Excel import/export for Laravel
MIT License
2.09k stars 246 forks source link

Import triggers tons of Spout warnings on php 8+ #269

Closed madsem closed 2 years ago

madsem commented 2 years ago

Spout warnings are triggered for every line I'm importing after updating to php 8.1.5

image

I believe this is related to #266, spout should be upgraded?

Example logs:

str_replace(): Passing null to parameter #1 ($search) of type array|string is deprecated in /var/task/vendor/box/spout/src/Spout/Reader/CSV/RowIterator.php on line 150

Return type of Box\Spout\Reader\CSV\SheetIterator::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/task/vendor/box/spout/src/Spout/Reader/CSV/SheetIterator.php on line 33

auto_detect_line_endings is deprecated in /var/task/vendor/box/spout/src/Spout/Reader/CSV/Reader.php on line 88
rap2hpoutre commented 2 years ago

We've just updated to openspout, it should work now. Could you update this package to v4.0.0?

hkirsman commented 1 year ago

That was good tip, tx!