Fixes GitHub Actions and the supported version.

rap2hpoutre / fast-excel

🦉 Fast Excel import/export for Laravel

MIT License

2.09k stars 246 forks source link

Closed crynobone closed 2 years ago

crynobone commented 2 years ago

openspout/openspout only support PHP 7.3 and above on the lowest 3.4.0 release. It not possible to run v4 on PHP 7.1 or 7.2
Without shivammathur/setup-php@v2 GitHub Action only runs the prebuilt PHP available on the ubuntu-latest build, which is why the above didn't fail until now. See https://github.com/crynobone/fast-excel/runs/7384019265?check_suite_focus=true

henryavila commented 2 years ago

@rap2hpoutre, can you accept this PR? The Laravel Nova Team fixed my CI Action.

They are waiting this merge to update rap2hpoutre/fast-excel on laravel/nova v4

rap2hpoutre commented 2 years ago

Do you mean Laravel/nova uses fast-excel? What an achievement then!