Fix extension install by making lsp an executable

rapgenic / zed-vhdl

VHDL Language support for Zed editor

4 stars 1 forks source link

Fix extension install by making lsp an executable #1

Closed Anthony-Eid closed 4 months ago

Anthony-Eid commented 4 months ago

Issue

When installing this extension through zed: install dev extension, the extension binary is not made an executable, causing this error No such file or directory (os error 2) when attempting to run the VHDL LSP.

Fix

This PR should fix it by calling zed::make_file_executable(&binary_path)

rapgenic commented 4 months ago

What OS are you on?

rapgenic commented 4 months ago

Ah never mind, you're probably on mac OS, given the .gitignore... In fact vhdl_ls binaries for Mac seem not to be executable.

rapgenic commented 4 months ago

merged manually

rapgenic commented 4 months ago

Thank you for the contribution!

Anthony-Eid commented 4 months ago

I'm was on macOS when I encountered that issue. BTW the snippet placeholder choices for zed is almost completely.