search

raphael-group / chisel

CHISEL -- Copy-number Haplotype Inference in Single-cell by Evolutionary Links
BSD 3-Clause "New" or "Revised" License
37 stars 11 forks source link

Assertions without error messages #7

Closed ivanov-v-v closed 4 years ago

ivanov-v-v commented 5 years ago

Dear Simone,

thank you once again for your package! It works on some of our datasets and does so decently. Unfortunately, on other datasets, it doesn't work, and I am currently debugging the code to identify the underlying issues. Currently, the pipeline fails on "selecting ploidies" step during the calling phase, on some of the assertions. And it is really tricky to figure out the actual problem because in the multiprocessing context the error reduces to

image

It would have been so much better if you could annotate the assertion statements. I tried to do that myself but the code in Caller.py was hard to follow. As this is only a preliminary release, I hope that all these suggestions will contribute to the tool development and better user experience in the future. When I find the actual bug, if there is one, I will also report it

simozacca commented 4 years ago

Some assertions are indeed missing a corresponding message and we are in process of fixing it. Thank you for the observation. I will keep the issue open until we add a message to each assertion.

simozacca commented 4 years ago

Assertion messages have been added in the last version