raphaelgoulart / ya_inputdisplay

Yet another input display for Clone Hero / YARG
16 stars 3 forks source link

Suggestions #25

Open Mapsking opened 3 months ago

Mapsking commented 3 months ago

-A scaling option might be nice, for higher DPI displays, and so the whole window can be scaled up or down, and not jut made wider/taller. Plus, it is kind of small to see sometimes.

-I think it would be nice to have a way to hide the top window border, as if the window is kept above other windows, the default Windows top bar is always visible.

-A way to record/playback all of your inputs for a song/instance of the program. Perhaps if you are struggling with something, it could be reviewed and played back to see what you missed, and help you make adjustments in the future?

raphaelgoulart commented 3 months ago

I like the ideas, not something I thought at first since the program is more aimed at OBS users (so you can reposition, resize etc. there), rather than at people who want to watch the input display in real time, as they play.

However, I'm terribly busy for an undeterminate amount of time, and won't be able to get to any of these any time soon. The issue will remain open, however, for whenever me or someone else have the time to get to it

  1. Great idea, agree that it can be small at times (though the initial idea was for the user to resize it in OBS);
  2. I'll have to check if it's possible in Godot (probably yes) If so, I'd make it a toggle ("Hide top window border"), being disabled by default.
  3. Don't get me wrong, I love the idea, but this is A. outside of the scope of the program, and B. could be used to facilitate cheating - input displays are often used by top players as an extra layer of credibility to their runs; something extra that people can use to verify whether a run is real, if the input display aligns with the game, the handcam (if any) etc. Replay playback would mess with things in that regard.

TL;DR 1. and 2. might be done in the future, but no promises.

Mapsking commented 3 months ago

Good points. I didn't think about using it in OBS, lol. I am getting ready to start streaming CH soon, I just never thought about it. How would I actually get it into OBS? Can it be used as a browser source by any chance in the future, or currently?

I also use a controller, so it might be nice to allow configuration of the whammy bar, and display it, as the program did not seem to. However, since it doesn't show the whammy currently anyways, it is likely not intended.

Regarding the other points, point 2 is kind of moot, I guess, since it is intended for OBS, but hey, maybe it could be an improvement at some point, but yes, it does seem irrelevant, since you can just move the window outside of the main OBS window.

3. TBH, I didn't even think about using this for cheating, but that's a

valid point, cheaters are everywhere, so don't feel any need to do it. I just like to watch when I play, ha ha. I currently use Gamepad Viewer, but it only displays the inputs, it doesn't keep track of how many times they are pressed and such.

One thing I forgot to mention, but maybe the row size should still have a separation between them? Maybe it is intended, but when they are set to a larger number, they all seem to override each other. Again this may not be relevant when things can be resized in OBS, but just thought I'd throw it out there. [image: image.png]

Finally, thanks for making the program, it seems to work well, and it is always nice to see tools like this. :-)

On Tue, Jul 9, 2024 at 7:11 PM Raphael Goulart @.***> wrote:

I like the ideas, not something I thought at first since the program is more aimed at OBS users (so you can reposition, resize etc. there), rather than at people who want to watch the input display in real time, as they play.

However, I'm terribly busy for an undeterminate amount of time, and won't be able to get to any of these any time soon. The issue will remain open, however, for whenever me or someone else have the time to get to it

  1. Great idea, agree that it can be small at times (though the initial idea was for the user to resize it in OBS);
  2. I'll have to check if it's possible in Godot (probably yes) If so, I'd make it a toggle ("Hide top window border"), being disabled by default.
  3. Don't get me wrong, I love the idea, but this is A. outside of the scope of the program, and B. could be used to facilitate cheating - input displays are often used by top players as an extra layer of credibility to their runs; something extra that people can use to verify whether a run is real, if the input display aligns with the game, the handcam (if any) etc. Replay playback would mess with things in that regard.

TL;DR 1. and 2. might be done in the future, but no promises.

— Reply to this email directly, view it on GitHub https://github.com/raphaelgoulart/ya_inputdisplay/issues/25#issuecomment-2219100873, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ427GENN63TKLJJX6VOV6DZLR33HAVCNFSM6AAAAABKTWZY2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZGEYDAOBXGM . You are receiving this because you authored the thread.Message ID: @.***>

-- Thanks, Steve

raphaelgoulart commented 3 months ago

To add it to OBS, just add it as a Game Capture source and enable transparency in the properties

Em ter., 9 de jul. de 2024 21:28, Mapsking @.***> escreveu:

Good points. I didn't think about using it in OBS, lol. I am getting ready to start streaming CH soon, I just never thought about it. How would I actually get it into OBS? Can it be used as a browser source by any chance in the future, or currently?

I also use a controller, so it might be nice to allow configuration of the whammy bar, and display it, as the program did not seem to. However, since it doesn't show the whammy currently anyways, it is likely not intended.

Regarding the other points, point 2 is kind of moot, I guess, since it is intended for OBS, but hey, maybe it could be an improvement at some point, but yes, it does seem irrelevant, since you can just move the window outside of the main OBS window.

3. TBH, I didn't even think about using this for cheating, but that's a

valid point, cheaters are everywhere, so don't feel any need to do it. I just like to watch when I play, ha ha. I currently use Gamepad Viewer, but it only displays the inputs, it doesn't keep track of how many times they are pressed and such.

One thing I forgot to mention, but maybe the row size should still have a separation between them? Maybe it is intended, but when they are set to a larger number, they all seem to override each other. Again this may not be relevant when things can be resized in OBS, but just thought I'd throw it out there. [image: image.png]

Finally, thanks for making the program, it seems to work well, and it is always nice to see tools like this. :-)

On Tue, Jul 9, 2024 at 7:11 PM Raphael Goulart @.***> wrote:

I like the ideas, not something I thought at first since the program is more aimed at OBS users (so you can reposition, resize etc. there), rather than at people who want to watch the input display in real time, as they play.

However, I'm terribly busy for an undeterminate amount of time, and won't be able to get to any of these any time soon. The issue will remain open, however, for whenever me or someone else have the time to get to it

  1. Great idea, agree that it can be small at times (though the initial idea was for the user to resize it in OBS);
  2. I'll have to check if it's possible in Godot (probably yes) If so, I'd make it a toggle ("Hide top window border"), being disabled by default.
  3. Don't get me wrong, I love the idea, but this is A. outside of the scope of the program, and B. could be used to facilitate cheating - input displays are often used by top players as an extra layer of credibility to their runs; something extra that people can use to verify whether a run is real, if the input display aligns with the game, the handcam (if any) etc. Replay playback would mess with things in that regard.

TL;DR 1. and 2. might be done in the future, but no promises.

— Reply to this email directly, view it on GitHub < https://github.com/raphaelgoulart/ya_inputdisplay/issues/25#issuecomment-2219100873>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AJ427GENN63TKLJJX6VOV6DZLR33HAVCNFSM6AAAAABKTWZY2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZGEYDAOBXGM>

. You are receiving this because you authored the thread.Message ID: @.***>

-- Thanks, Steve

— Reply to this email directly, view it on GitHub https://github.com/raphaelgoulart/ya_inputdisplay/issues/25#issuecomment-2219155860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSNO3MEO6J6OBLAB4ZJACDZLR52BAVCNFSM6AAAAABKTWZY2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZGE2TKOBWGA . You are receiving this because you commented.Message ID: @.***>

SkyJumper409x commented 1 month ago

I also use a controller, so it might be nice to allow configuration of the whammy bar, and display it, as the program did not seem to. However, since it doesn't show the whammy currently anyways, it is likely not intended.

I have experimented with visualizations for whammy, but so far have had trouble both with calibration and finding a good visual representation for it. I will keep it in the back of my head, though

point 2 is kind of moot, [...], since you can just move the window outside of the main OBS window.

You can also crop the source by holding alt while dragging the borders around

  1. TBH, I didn't even think about using this for cheating, but that's a valid point, cheaters are everywhere, [...]

It would be good to have some form of indicator for playback, maybe just a blatant "REPLAY MODE" at the top, maybe a more hidden "watermark" approach, or just not updating the input counters during playback as an indicator. Just a replay feature without further indication of the inputs being replayed will cause problems with cheaters though, i agree.

One thing I forgot to mention, but maybe the row size should still have a separation between them? [...] when they are set to a larger number, they all seem to override each other.

I am assuming you are talking about the "Input Bar Width" Setting here? That already existed by config editing in versions 0.0.4 and older (aka before there was a GUI for configuration). When creating the GUI, i decided to set an upper bound to avoid integer overflow, but I did allow quite large values. The original intent of that setting was probably to make the Input Bar Width smaller, not larger (though it would be good to know from @raphaelgoulart what to do about this, i agree it looks quite messy).

SkyJumper409x commented 1 month ago

-A scaling option might be nice, for higher DPI displays, and so the whole window can be scaled up or down, and not jut made wider/taller. Plus, it is kind of small to see sometimes.

I agree, this would also be better than scaling it in OBS since that looks kinda bad, it would be better to scale the resolution up along with the buttons. If I recall correctly, most size/position values are currently set in pixels, so it would be required to either figure out how to scale based on that, or rearrange the positions using anchors and relative positions as opposed to absolute pixel values.

Mapsking commented 3 weeks ago

Just curious, I know someone that uses this input display on their Twitch streams. I've noticed that their up and down strums always register both for each input, so they will have the same amount. IIRC, when I tested it, it showed them differently. Is there a bug that would cause up and down strums to display the same count every time? Here is a video that you can see it in.

https://www.youtube.com/watch?v=qLQqJ9oVPw4

Is there a setting that maybe I can suggest to him to double check? It is likely something on his end, but not sure. He seemed to think they always did that. I think he was using the Ardwiino option, so maybe he needs to upgrade to the Santroller firmware? Not sure if he has or not, but wanted to ask you, in case you had any specific suggestions I can relay to him.

Thanks, Steve

On Sat, Aug 31, 2024 at 12:06 PM SkyJumper409x @.***> wrote:

-A scaling option might be nice, for higher DPI displays, and so the whole window can be scaled up or down, and not jut made wider/taller. Plus, it is kind of small to see sometimes.

I agree, this would also be better than scaling it in OBS since that looks kinda bad, it would be better to scale the resolution up along with the buttons. If I recall correctly, most size/position values are currently set in pixels, so it would be required to either figure out how to scale based on that, or rearrange the positions using anchors and relative positions as opposed to absolute pixel values.

— Reply to this email directly, view it on GitHub https://github.com/raphaelgoulart/ya_inputdisplay/issues/25#issuecomment-2322971099, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ427GGWA4Z3RZMYENB5TU3ZUHZX3AVCNFSM6AAAAABKTWZY2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSHE3TCMBZHE . You are receiving this because you authored the thread.Message ID: @.***>

raphaelgoulart commented 3 weeks ago

@Mapsking that is an entirely different input viewer

raphaelgoulart commented 3 weeks ago

Although, apparently that can be fixed by following this guide (be sure to read the description though)

Mapsking commented 3 weeks ago

Oh, I guess I didn't even notice, ha ha. Thanks for letting me know. Sorry about that. I play on a controller, so initially I didn't even notice it, lol.

On Tue, Oct 1, 2024 at 5:15 PM Raphael Goulart @.***> wrote:

@Mapsking https://github.com/Mapsking that is an entirely different input viewer https://github.com/marikogh/CHInputViewr

— Reply to this email directly, view it on GitHub https://github.com/raphaelgoulart/ya_inputdisplay/issues/25#issuecomment-2387180799, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ427GCO5O264ICDGR7FBUDZZMNILAVCNFSM6AAAAABKTWZY2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBXGE4DANZZHE . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks, Steve