search

raphaelhanneken / apple-juice

An advanced battery gauge for macOS, that displays the remaining battery time and more.
MIT License
510 stars 34 forks source link

'%' should not have preceding space #17

Closed mayankk2308 closed 5 years ago

mayankk2308 commented 5 years ago

Minor gripe, but in Apple's default battery icon, there is no space preceding the % sign. Example: 87% and not 87 %. Would be great if the app could conform to this.

camlloyd commented 5 years ago

@mayankk2308 I've removed the space in my local version, but this looks to be a localisation thing.

In German, there is a space preceding the % sign on macOS. In English (UK), there is no preceding space.

@raphaelhanneken, would it be possible to implement whether whitespace precedes the % sign or not based on preferred language (like in macOS)? You already have Localizable.strings...

Thanks!

raphaelhanneken commented 5 years ago

Apple Juice v1.9.0 now uses NumberFormatter to localise the percentage. Thanks for reporting this 👍

camlloyd commented 5 years ago

For completeness, is it possible to implement this for the notification percentages also?

raphaelhanneken commented 5 years ago

Oops... of course. I forgot about the notifications - I'll adjust the texts asap. 😅

raphaelhanneken commented 5 years ago

Notification percentages should be localised too, with v1.10.0.

camlloyd commented 5 years ago

Notification percentages should be localised too, with v1.10.0. @raphaelhanneken does this affect the percentages in the Notifications submenu?