search

raphaelm / python-fints

Pure-python FinTS (formerly known as HBCI) implementation
https://pypi.python.org/pypi/fints
GNU Lesser General Public License v3.0
328 stars 81 forks source link

Comdirect support #142

Closed rhn closed 2 years ago

rhn commented 2 years ago

This is just a copy of https://github.com/raphaelm/python-fints/pull/129 for easy merging.

The previous author bumped the version because the compatibility with older Pythons was left behind. (I don't know where exactly.)

This rebased version is also compatible with Python 3.10.

raphaelm commented 2 years ago

Uh, thanks, I'll try to find some time to test this. I don't have a comdirect account, but I do have phototan, so I'd be curious if it works with others as well

Ferenc- commented 2 years ago

@rhn I am under the impression, that the decode_phototan_image is already implemented here. I have been using challenge_matrix[1] for quite a while without any issue. Do we really need decode_phototan_image?

raphaelm commented 2 years ago

I pushed a little cleanup – please don't mix version number increases with other changes!

raphaelm commented 2 years ago

I reverted after the merge since indeed it was duplicate but now we at least have it covered in docs!