search

raphaelm / python-sepaxml

SEPA Direct Debit XML generation in python
MIT License
112 stars 43 forks source link

Implemented pain.008.003.02 transactions without BIC #25

Closed alphanoob1337 closed 4 years ago

alphanoob1337 commented 4 years ago

Added support for payment information and configuration without BIC for pain.008.003.02 scheme.

raphaelm commented 4 years ago

Thanks a lot! Can you resolve the two style issues?

sepaxml/debit.py:456:1: W293 blank line contains whitespace

tests/test_no_bic_00800302.py:15:9: E265 block comment should start with '# '
codecov[bot] commented 4 years ago

Codecov Report

Merging #25 into master will decrease coverage by 0.57%. The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage    97.3%   96.73%   -0.58%     
==========================================
  Files          22       23       +1     
  Lines         854      888      +34     
==========================================
+ Hits          831      859      +28     
- Misses         23       29       +6
Impacted Files Coverage Δ
tests/test_no_bic_00800302.py 100% <100%> (ø)
sepaxml/debit.py 95.89% <70%> (-1.76%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98934ba...425afaf. Read the comment docs.