search

raphaelm / python-sepaxml

SEPA Direct Debit XML generation in python
MIT License
110 stars 41 forks source link

Remove BIC from transfers' required fields #26

Closed simone-pignotti closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #26 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files          23       23           
  Lines         888      888           
=======================================
  Hits          859      859           
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5751fd4...63b479d. Read the comment docs.

raphaelm commented 4 years ago

Do you happen to know if this is valid for all of the PAIN versions or only the newer ones?

frzb commented 4 years ago

@raphaelm please merge this. :pray:

As far as I understand the EU Regulation No 260/2012 enforces an "IBAN only" policy since 2016. I really need the feature to go without the BIC - because the customer data at work no longer contains BIC data. Until now I had to build the wheel package from this patch on my own. Which adds a lot of hustle in deploying the application.

raphaelm commented 4 years ago

Sorry, I had a lot on my hands in the last weeks