search

raphaelm / python-sepaxml

SEPA Direct Debit XML generation in python
MIT License
110 stars 41 forks source link

Support non-SEPA payments as well #30

Closed MarcelWaldvogel closed 3 years ago

MarcelWaldvogel commented 3 years ago

Specifying domestic attribute will suppress elements for SvcLvl code "SEPA". This is necessary for transactions within CH/LI, where SEPA transfers are refused. This is weird, IMHO, but specified in the Swiss Business Rules and observed by banks.

codecov[bot] commented 3 years ago

Codecov Report

Merging #30 (bf29560) into master (5d209df) will increase coverage by 0.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   96.73%   96.91%   +0.18%     
==========================================
  Files          23       24       +1     
  Lines         888      908      +20     
==========================================
+ Hits          859      880      +21     
+ Misses         29       28       -1
Impacted Files Coverage Δ
sepaxml/transfer.py 97.51% <100.00%> (+0.47%) :arrow_up:
tests/transfer/test_domestic.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d209df...705d1a0. Read the comment docs.

lienharc commented 3 years ago

Is it possible to release a new version including this change?