search

raphaelm / python-sepaxml

SEPA Direct Debit XML generation in python
MIT License
110 stars 43 forks source link

Add schema pain.001.003.03 #31

Closed tloebhard closed 2 years ago

tloebhard commented 3 years ago

Added pain.001.003.03.xsd as a copy of pain.001.001.03.xsd (with adjusted namespace). Fixes #20

codecov[bot] commented 3 years ago

Codecov Report

Merging #31 (db2331f) into master (696d45b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files          23       23           
  Lines         906      906           
=======================================
  Hits          879      879           
  Misses         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 696d45b...db2331f. Read the comment docs.

MoritzFago commented 3 years ago

What's the status on this? This missing currently breaks sepa transfers for byro-fints.

tloebhard commented 3 years ago

@MoritzFago does my pull request (adding just the file...) also fix your issue?

raphaelm commented 2 years ago

Sorry for not merging this, just copying the file and renaming it doesn't feel right, we should actually use the correct schema. See df5eb8d

tloebhard commented 2 years ago

Sorry for not merging this, just copying the file and renaming it doesn't feel right, we should actually use the correct schema. See df5eb8d

Indeed, that was no famous solution - just pragmatic, as explained in #20 .

Thank you for solving!